vba - Excel Macro Copying A Single Row It Shouldn't -


i have macro designed copy row's contents separate sheet based on value contained in 1 of several columns click of button, contained on originating sheet:

private sub commandbutton1_click()  application.screenupdating = false application.enableevents = false application.calculation = xlcalculationmanual  dim longlastrow long dim cancelled worksheet, discontinued worksheet, notconf24 worksheet, esdout worksheet, notconfship worksheet, notconfship24 worksheet  set cancelled = sheets("cancelled") set discontinued = sheets("discontinued") set notconf24 = sheets("notconfavail24hr") set esdout = sheets("esdoutsideleadtime") set notconfshiplead = sheets("notconfbutshipinlead") set notconfship24 = sheets("notconfship24hrs")  longlastrow = cells(rows.count, "a").end(xlup).row  range("a2", "t" & longlastrow)     .autofilter     .autofilter field:=13, criteria1:="yes"     .copy cancelled.range("a1")     .autofilter field:=14, criteria1:="yes"     .copy discontinued.range("a1")     .autofilter field:=15, criteria1:="no"     .copy notconf24.range("a1")     .autofilter field:=16, criteria1:="yes"     .copy notconfshiplead.range("a1")     .autofilter field:=18, criteria1:="no"     .copy notconfship24.range("a1")     .autofilter end  application.screenupdating = true application.enableevents = true application.calculation = xlcalculationautomatic  end sub

the problem i'm having it's copying first row in range, a2, every sheet if doesn't meet criteria. have little experience working vba. got macro here , have perused significant number of other articles pertaining type of function, have tried many of solutions offered, , have come short each time.

in post linked above, 1 user had similar problem (it copied first row in range), , suggested due fact column a might not contain value on actual last row content; however, in case does. columns between a , t have value.

other that, macro works great! able sort ~10,000 rows in less second.

pls try this:

private sub commandbutton1_click()  application.screenupdating = false application.enableevents = false application.calculation = xlcalculationmanual  dim longlastrow long dim cancelled worksheet, discontinued worksheet, notconf24 worksheet, esdout worksheet, notconfship worksheet, notconfship24 worksheet  set cancelled = sheets("cancelled") set discontinued = sheets("discontinued") set notconf24 = sheets("notconfavail24hr") set esdout = sheets("esdoutsideleadtime") set notconfshiplead = sheets("notconfbutshipinlead") set notconfship24 = sheets("notconfship24hrs")  longlastrow = cells(rows.count, "a").end(xlup).row  dim cpyrng range set cpyrng = range("a3", "t" & longlastrow)  range("a2", "t" & longlastrow)     .autofilter     .autofilter field:=13, criteria1:="yes"     cpyrng.copy cancelled.range("a1")     .autofilter field:=14, criteria1:="yes"     cpyrng.copy discontinued.range("a1")     .autofilter field:=15, criteria1:="no"     cpyrng.copy notconf24.range("a1")     .autofilter field:=16, criteria1:="yes"     cpyrng.copy notconfshiplead.range("a1")     .autofilter field:=18, criteria1:="no"     cpyrng.copy notconfship24.range("a1")     .autofilter end  application.screenupdating = true application.enableevents = true application.calculation = xlcalculationautomatic  end sub

you change cpyrng. .offset(1).resize(.rows.count - 1). , skip out whole cpyrng-variable way...

still, i'm sure should easy fast solution :)


Comments

Post a Comment

Popular posts from this blog

authentication - Mongodb revoke acccess to connect test database -

i have ec2 instance mongodb 3.2.0 installed. have user admin access. can connect user , perform operation remotely. 1 can connect database test remote if knows ip mongo 11.11.11.11. although not able make operations, want restrict access user credentials can connect server. first need create users , grant roles users, example: use admin db.createuser( { user: "myuseradmin", pwd: "abc123", roles: [ { role: "useradminanydatabase", db: "admin" } ] } ) then need start server --auth parameter mongod --auth more information here
Read more

r - Update two sets of radiobuttons reactively - shiny -

i have read ( how make choices in radiobuttons reactive in shiny? ) shows me how update radiobutton s in reactive way. however, when try , update 2 sets of buttons same data, 1 set renders. example: server: # create example data wafer <- rep(c(1:3), each=3) length <- c(1,1,2,1,1,1,3,5,1) width <- c(3,1,6,1,1,1,1,1,6) dd <- data.frame(wafer, length, width) shinyserver(function(input, output, session){ # create reactive dataframe store data values <- reactivevalues() values$df <- data.frame() # lengths , widths of wafer user input <- eventreactive(input$do, { subset(dd, wafer %in% input$wafer, select = length:width) }) # update reactive data frame lengths , widths have been selected user input observe({ if(!is.null(a())) { values$df <- rbind(isolate(values$df), a()) } }) output$wl <- renderdatatable({ a() }) # update radio buttons unique length , widths stored in values$df # ever "observe" put first in co...
Read more

ios - Realm over CoreData should I use NSFetchedResultController or a Dictionary? -

i'm working on app using core data , nsfetchedresultcontroller many reasons switch use realm. saw there "realm version" of nsfetchedresultcontroller on github wouldn't compatible current code using core data. the view controller displaying list of people same school, address book. list sublist of people studied in same city. so thinking make 1 unique request database retrieve list of people , filter locally list within 1 dictionary per school [string: anyobject] string section name within tableview , anyobject array of people. first solution, make nsfetchedresultcontroller each school predicate filtering location. delete actions etc.. handled delegates -> not compatible realm create dictionaries , update them each actions... -> works realm it's annoying code. any better solution? edit: i need clarify request: i'd write class inherit uitableviewcontroller. this class has list of people sorted in alphabetical order the tableview has ...
Read more