delphi - TShellTreeView memory leak -


i'm using madexcept trace memory leaks. if put tshelltreeview on form , run application madexcept reports memory leak. opening , closing, nothing else. using xe6 package under xe8, since last 1 released afaik.

i know there problems former delphi versions, these fixed in xe6 package, think.

this madexcept window shown after app shutdown:

madexcept screenshot

any ideas?

yes, madexcept correct expected because of exceptionally high quality. indeed defect in code use. looks this:

function createrootfolder(rootfolder: tshellfolder; oldroot : troot;   var newroot: troot): tshellfolder; var   p: pwidechar;   newpidl: pitemidlist;   numchars,   flags,   hr: longword;   errormsg : string; begin   hr := s_false;   if getenumvalue(typeinfo(trootfolder), newroot) >= 0   begin     hr := shgetspecialfolderlocation(             0,             nfolder[getcsidltype(newroot)],             newpidl);   end   else if length(newroot) > 0   begin     if newroot[length(newroot)] = ':' newroot := newroot + '\';     numchars := length(newroot);     flags := 0;     p := stringtoolestr(newroot);     hr := desktopshellfolder.parsedisplayname(0, nil, p, numchars, newpidl, flags);   end;    if hr <> s_ok   begin     { todo : remove next line? }     // result := rootfolder;     errormsg := format( serrorsettingpath, [ newroot ] );     newroot := oldroot;     raise exception.create( errormsg );   end;    result := createrootfrompidl(newpidl);   if assigned(rootfolder) rootfolder.free; end;

in both branches, responsibility of caller destroy newpidl. code not so. can discerned reading documentation:

amend final part of function so:

result := createrootfrompidl(newpidl); if assigned(rootfolder) rootfolder.free; cotaskmemfree(newpidl);

i can confirm have tested change. tested original code , reproduced leak reported. changed code described above , madexcept reports no leak.

that have been unable achieve same means not executing modified code. perhaps using runtime packages , have not recompiled modified code. or perhaps there explanation. anyway, clear me failure remove leak because still running original unmodified code.


Comments

Post a Comment

Popular posts from this blog

authentication - Mongodb revoke acccess to connect test database -

i have ec2 instance mongodb 3.2.0 installed. have user admin access. can connect user , perform operation remotely. 1 can connect database test remote if knows ip mongo 11.11.11.11. although not able make operations, want restrict access user credentials can connect server. first need create users , grant roles users, example: use admin db.createuser( { user: "myuseradmin", pwd: "abc123", roles: [ { role: "useradminanydatabase", db: "admin" } ] } ) then need start server --auth parameter mongod --auth more information here
Read more

r - Update two sets of radiobuttons reactively - shiny -

i have read ( how make choices in radiobuttons reactive in shiny? ) shows me how update radiobutton s in reactive way. however, when try , update 2 sets of buttons same data, 1 set renders. example: server: # create example data wafer <- rep(c(1:3), each=3) length <- c(1,1,2,1,1,1,3,5,1) width <- c(3,1,6,1,1,1,1,1,6) dd <- data.frame(wafer, length, width) shinyserver(function(input, output, session){ # create reactive dataframe store data values <- reactivevalues() values$df <- data.frame() # lengths , widths of wafer user input <- eventreactive(input$do, { subset(dd, wafer %in% input$wafer, select = length:width) }) # update reactive data frame lengths , widths have been selected user input observe({ if(!is.null(a())) { values$df <- rbind(isolate(values$df), a()) } }) output$wl <- renderdatatable({ a() }) # update radio buttons unique length , widths stored in values$df # ever "observe" put first in co...
Read more

ios - Realm over CoreData should I use NSFetchedResultController or a Dictionary? -

i'm working on app using core data , nsfetchedresultcontroller many reasons switch use realm. saw there "realm version" of nsfetchedresultcontroller on github wouldn't compatible current code using core data. the view controller displaying list of people same school, address book. list sublist of people studied in same city. so thinking make 1 unique request database retrieve list of people , filter locally list within 1 dictionary per school [string: anyobject] string section name within tableview , anyobject array of people. first solution, make nsfetchedresultcontroller each school predicate filtering location. delete actions etc.. handled delegates -> not compatible realm create dictionaries , update them each actions... -> works realm it's annoying code. any better solution? edit: i need clarify request: i'd write class inherit uitableviewcontroller. this class has list of people sorted in alphabetical order the tableview has ...
Read more