Refactoring using Java 8 -


i want refactor code using java 8, thought instead of using setter method this:

    class myservice{     user user = new user();     user.setname(response.getname());     user.setid(response.getid());     user.settype(response.gettype());     user.setdesignation(response.getdesignation()); } 

in service class.

i made method in user pojo

class user{      public static user create(response response){     user user = new user();     user.setname(response.getname());     user.setid(response.getid());     user.settype(response.gettype());     user.setdesignation(response.getdesignation());     return user;     } } 

and in service class, wrote:

list<user> userlist=reponselist.stream().map(user::create).collect(tolist()); 

is right way or better solution other this? have lot of setter methods in service.

instead of creating static create method, define user constructor takes response , initializes that.

class user{      public user(response response) {                 setname(response.getname());         setid(response.getid());         settype(response.gettype());         setdesignation(response.getdesignation());     }  } 

then can call:

list<user> userlist=responselist.stream().map(user::new).collect(tolist()); 

Comments

Popular posts from this blog

php - Wordpress website dashboard page or post editor content is not showing but front end data is showing properly -

How to get the ip address of VM and use it to configure SSH connection dynamically in Ansible -

javascript - Get parameter of GET request -