javascript - Alternate structure for a sequence of If statements? -


i'm programming poker program in javascript. have hand class has properties "cards", "value" , "valuecards". value property integer corresponds hand type, , valuecards array of 5 cards corresponds hand type. example, if original 7 cards(contained in cards property) contains flush, this.value flip 6, , this.valuecards equal 5 cards equal highest flush.

i have 1 method each hand type, , of them change value , valuecards if hand type detected. have accessor method value called getvalue, when went make method run tests on hand , keep highest one, came out looking this:

poker.hand.prototype.gettruevalue = function () {     this.teststraightflush();     if(this.value == poker.hand_type.straight_flush){ return; }      this.testquads();     if(this.value == poker.hand_type.quads){ return; }      this.testfullhouse();     if(this.value == poker.hand_type.full_house){ return; }      this.testflush();     if(this.value == poker.hand_type.flush){ return; }      this.teststraight();     if(this.value == poker.hand_type.straight){ return; }      this.testtrips();     if(this.value == poker.hand_type.trips){ return; }      this.testtwopair();     if(this.value == poker.hand_type.two_pair){ return; }      this.testpair();     if(this.value == poker.hand_type.pair){ return; }      this.gethighcards(); };

i mean, method works fine. bothers me, maybe should doing different way. go against convention?

if change this.test* functions return true if "hand" found, or return false if not - ugly, yet somehow satisfying, as

poker.hand.prototype.gettruevalue = function () {     this.teststraightflush() ||     this.testquads() ||     this.testfullhouse() ||     this.testflush() ||     this.teststraight() ||     this.testtrips() ||     this.testtwopair() ||     this.testpair() ||     this.gethighcards(); };

or

change this.test* functions check if this.found false, , set this.found = true if hand found, you'd simply

poker.hand.prototype.gettruevalue = function () {     this.found = false;     this.teststraightflush();     this.testquads();     this.testfullhouse();     this.testflush();     this.teststraight();     this.testtrips();     this.testtwopair();     this.testpair();     this.gethighcards(); };

Comments

Post a Comment

Popular posts from this blog

php - Wordpress website dashboard page or post editor content is not showing but front end data is showing properly -

Image
recently have uploaded wordpress site onto server. have uploaded wordpress site in sub-folder under root folder ../root(domain root folder)/wordpress (where host wordpress folder). now problem content data in page or post in dashboard of wordpress admin panel not showing - see image. but data showing in front view - see image. if not browser cache issue , not issue happened tinymce editor during upgrade; try add config file: define('concatenate_scripts', false);
Read more

How to get the ip address of VM and use it to configure SSH connection dynamically in Ansible -

i trying ip address of vm , trying use establish ssh vm. following script: --- - hosts: localhost become: yes connection: local gather_facts: false serial: 1 vars_files: - createvmvars.yml tasks: - name: gathering vm info. vsphere_guest: vcenter_hostname: "{{vcenter_hostname}}" username: "{{vcenter_username}}" password: "{{vcenter_password}}" guest: "{{guest_name}}" vmware_guest_facts: yes register: var - debug: msg="{{var.ansible_facts.hw_eth0.ipaddresses[0]}}" - name: establishing ssh connection. script: /home/shasha/devops/scripts/ssh_configure.sh "{{var.ansible_facts.hw_eth0.ipaddresses[0]}}" following content of ssh_configure.sh : #!/bin/sh ssh-keygen -t rsa ssh-copy-id $1 but when running playbook, getting following error while executing third task: error! 'var' undefined but debug module(second task) printin
Read more

javascript - Get parameter of GET request -

i make request: createxhrrequest( "get", fileurl, function( err, response ) { if( err ) { alert( "error get!" ); } alert(response); }); and full response: { "status" : "ok", "message" : "jvberi0xljqkjdduxdgkmy how can jvberi0xlj ? i try response.message , response["message"]. nothing works. just simple access this: var json = json.parse(response); json.message
Read more